Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding ip_discovery and network_type for elasticache replication group #28306

Conversation

jms200
Copy link
Contributor

@jms200 jms200 commented Dec 12, 2022

Description

Adds the ip_discovery parameter to elasticache replication group that is now supported on Redis 6.2 and Memcached engine version 1.6.6 on all instances built on the Nitro system.

Relations

Closes #28131

References

API Documentation: https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_ReplicationGroup.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2022
@jms200
Copy link
Contributor Author

jms200 commented Dec 12, 2022

This is still a work in progress and need to get the tests written for the replication group. Additionally need to look into the datasource bits as well.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. labels Dec 12, 2022
@jms200 jms200 changed the title Adding ip_discovery and network_type Adding ip_discovery and network_type for elasticache replication group Dec 12, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2022
@justinretzolk justinretzolk changed the title Adding ip_discovery and network_type for elasticache replication group [WIP] Adding ip_discovery and network_type for elasticache replication group Dec 13, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 5, 2023
internal/service/elasticache/replication_group_test.go Outdated Show resolved Hide resolved
website/docs/r/elasticache_replication_group.html.markdown Outdated Show resolved Hide resolved
.changelog/28306.txt Outdated Show resolved Hide resolved
@jms200
Copy link
Contributor Author

jms200 commented Feb 9, 2023

Currently working through issues with getting acceptance testing to complete.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 9, 2023
@kedare
Copy link

kedare commented Jul 4, 2023

Hello.

Is there any news on this ? Any help needed ?

Thanks.

@kbergha
Copy link

kbergha commented Aug 17, 2023

Hi. Any hope of getting this updated for 5.x (if needed) and merged?

@otyaglo
Copy link

otyaglo commented Aug 24, 2023

@bschaatsbergen @jms200 @binxio - what would it take to get this into next release?

@larsboldt
Copy link

We need this to properly support IPv6 which is required by law in Norway - please prioritize merging.

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Sep 12, 2023

I'll happily take a stab at it after my holiday @larsboldt

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Oct 19, 2023

I'm moving the fixes into a new branch and PR as I have no write access on the fork, please follow #34019

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws_elasticache_replication_group]: add support for network_type and ip_discovery arguments
8 participants