Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts AWS API calls to and provider CRUD calls to Context-aware versions #29005

Merged
merged 222 commits into from
Jan 20, 2023

Conversation

gdavison
Copy link
Contributor

Converts AWS API calls to and provider CRUD calls to Context-aware versions.

Required for #26029 implementation

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jan 20, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Reviewed all changes outside internal/service)

Should we update skaff to use context aware functions as well?

@gdavison
Copy link
Contributor Author

I made some changes to the skaff templates in 26f786e

@gdavison gdavison merged commit 5857c14 into main Jan 20, 2023
@gdavison gdavison deleted the td-context-everywhere branch January 20, 2023 16:56
@github-actions github-actions bot added this to the v4.52.0 milestone Jan 20, 2023
@jar-b
Copy link
Member

jar-b commented Jan 20, 2023

I made some changes to the skaff templates in 26f786e

🤦 github cut off the changes at 3000 files. thanks for clarifying.

@kamilturek
Copy link
Collaborator

kamilturek commented Jan 20, 2023

Hey, @gdavison 👋 Impressive work!

Is there a plan to update the docs section about acceptance tests and sweepers to reflect the changes there?

CheckDestroy: testAccCheckDashboardDestroy,

Sorry if I missed it!

@github-actions
Copy link

This functionality has been released in v4.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants