Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ses_configuration_set: reflect tracking_options in state #35056

Merged
merged 3 commits into from
Jan 2, 2024
Merged

r/aws_ses_configuration_set: reflect tracking_options in state #35056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d5d12c
Add tracking options to list of retrieved attribute names
kamilturek Dec 22, 2023
eb24a02
Add tracking_options example
kamilturek Dec 22, 2023
46b5523
Add changelog
kamilturek Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/35056.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_ses_configuration_set: Fix `tracking_options` being omitted from state and resulting in persistent diff
```
4 changes: 3 additions & 1 deletion internal/service/ses/configuration_set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ func resourceConfigurationSetRead(ctx context.Context, d *schema.ResourceData, m
ConfigurationSetName: aws.String(d.Id()),
ConfigurationSetAttributeNames: aws.StringSlice([]string{
ses.ConfigurationSetAttributeDeliveryOptions,
ses.ConfigurationSetAttributeReputationOptions}),
ses.ConfigurationSetAttributeReputationOptions,
ses.ConfigurationSetAttributeTrackingOptions,
}),
}

response, err := conn.DescribeConfigurationSetWithContext(ctx, configSetInput)
Expand Down
14 changes: 14 additions & 0 deletions website/docs/r/ses_configuration_set.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Provides an SES configuration set resource.

## Example Usage

### Basic Example

```terraform
resource "aws_ses_configuration_set" "test" {
name = "some-configuration-set-test"
Expand All @@ -30,6 +32,18 @@ resource "aws_ses_configuration_set" "test" {
}
```

### Tracking Options

```terraform
resource "aws_ses_configuration_set" "test" {
name = "some-configuration-set-test"

tracking_options {
custom_redirect_domain = "sub.example.com"
}
}
```

## Argument Reference

The following argument is required:
Expand Down
Loading