Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azuread_application_platform #501

Closed
channaj opened this issue Jul 25, 2021 · 2 comments · Fixed by #1214
Closed

New resource azuread_application_platform #501

channaj opened this issue Jul 25, 2021 · 2 comments · Fixed by #1214

Comments

@channaj
Copy link

channaj commented Jul 25, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently, platform configuration is implemented as part of the azuread_application resource. There seems to be scenarios - I have come across at least one - where this is not ideal. When configuring a nativeClient platform, in some (probably most) cases we need to know the application (client) id of the Azure AD Application in order to be able to configure redirect uris (please see ms-appx-web: uri below)

If we have azuread_application_platform as an independent resource (as mentioned in the potential configuration) we'll be able to solve the above problem. This would also be better aligned with the concept of "Platform configurations" of Azure AD Application.

New or Affected Resource(s)

  • azuread_application
  • azuread_application_platform

Potential Terraform Configuration

resource "azuread_application" "example" {
...
}

resource "azuread_application_platform" "web" {
  application_object_id = azuread_application.example.object_id
  type = "web"
  
  homepage_url  = "https://app.example.net"
  logout_url    = "https://app.example.net/logout"
  redirect_uris = ["https://app.example.net/account"]

  implicit_grant {
    ...
  }
}

resource "azuread_application_platform" "public_cient" {
  application_object_id = azuread_application.example.object_id
  type = "publicClient"
  
  redirect_uris = [
      "https://login.microsoftonline.com/common/oauth2/nativeclient"
      "ms-appx-web://microsoft.aad.brokerplugin/${azuread_application.example.application_id}"
  ]
}

References

@manicminer
Copy link
Contributor

Thanks for the suggestion @channaj. Needing to know the application ID is something that has come up in a couple of different contexts and we'll look to solve this.

@manicminer manicminer added this to the v2.1.0 milestone Jul 26, 2021
@manicminer manicminer modified the milestones: v2.1.0, v2.2.0, v2.3.0 Sep 1, 2021
@manicminer manicminer modified the milestones: v2.3.0, v2.4.0, v2.5.0 Sep 15, 2021
@manicminer manicminer modified the milestones: v2.5.0, v2.6.0 Sep 30, 2021
@mausv
Copy link

mausv commented Nov 17, 2021

Any update on this?

@manicminer manicminer added this to the v2.44.0 milestone Oct 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants