[MS] Resolve #96, Making Name in VMSS storage_profile_os_disk Optional #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VMSS Tests pass: |
tombuildsstuff
approved these changes
Jun 27, 2017
There was a problem hiding this comment.
Hey @echuvyrov
Thanks for this PR - I've taken a look and besides one minor nit - this LGTM :)
Thanks!
| @@ -898,6 +916,68 @@ resource "azurerm_virtual_machine_scale_set" "test" { | |||
| } | |||
| ` | |||
|
|
|||
| var testAccAzureRMVirtualMachineScaleSet_basicLinux_managedDiskNoName = ` | |||
There was a problem hiding this comment.
minor: for newer tests we're switching to use a function which returns a formatted string
tombuildsstuff
added a commit
that referenced
this pull request
Jun 27, 2017
tombuildsstuff
added a commit
that referenced
this pull request
Jul 4, 2017
[MS] Resolve #96, Making Name in VMSS storage_profile_os_disk Optional
tombuildsstuff
added a commit
that referenced
this pull request
Jul 4, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made Name field optional in storage_profile_os_disk. After this change, the behavior becomes as follows:
Managed Disk:
Name field missing = Pass
Name set to "" = Pass
Name set to any other value = Fail with error
Unmanaged Disk
Name not set = Fail with error
Resolves #96