Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_machine - making admin_password optional for Linux VM's #154

Merged
merged 2 commits into from
Jul 5, 2017

Conversation

tombuildsstuff
Copy link
Contributor

As explained in #152 - it's possible to create a Linux VM using only SSH Keys - meaning the admin_password field can become optional.

Fixes #152

Running the test suite now..

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks overall good to me, just one question, possibly unrelated to the original intention of this PR, but still valid, IMO.

@@ -334,7 +334,7 @@ func resourceArmVirtualMachine() *schema.Resource {

"admin_password": {
Type: schema.TypeString,
Required: true,
Optional: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also mark this as Sensitive so it doesn't show up in the plan/apply output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably - I'll update this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(done)

}

os_profile {
computer_name = "hn%d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any special meaning behind the two letters hn? 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied it from the example above, but presumably hostname :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's hn - we kept this short as Windows host names cannot be more than 16 characters

@tombuildsstuff
Copy link
Contributor Author

Ignoring a subscription-specific test failure, the tests pass:
screen shot 2017-07-05 at 08 12 55

@tombuildsstuff tombuildsstuff merged commit caed772 into master Jul 5, 2017
@tombuildsstuff tombuildsstuff deleted the vm-nopassword branch July 5, 2017 07:15
tombuildsstuff added a commit that referenced this pull request Jul 5, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_machine requires an admin_password when disable_password_authentication is set
3 participants