-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Import support to Search Service #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks functionally good to me, but I'm not sure the %+v
is a good idea.
I understand the motivation is probably to get all the details about the error (including type, code etc.), so we can then easily catch it if necessary, but I think this is developer's concern, not user's.
User should see a user-friendly error, which is hopefully what %s
provides - i.e. the String()
or default string representation of that error is user-friendly.
That said I'm not familiar with error handling conventions in Azure, so I might not know the full background.
|
||
## Import | ||
|
||
Search Services can be imported using the `resource id`, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the intention here was to put back ticks just around id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do, but we should update all of them to match this, as this was C&P'd from an existing page for consistency (example)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Adding Import support to
azurerm_search_service
Tests pass: