Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_new_relic_monitor #21958

Merged
merged 9 commits into from
Jun 21, 2023

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented May 30, 2023

Swagger:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/newrelic/resource-manager/NewRelic.Observability/stable/2022-07-01/NewRelic.json

Test Result:

Please Register NewRelic.Observability to your subscription before testing.
image

--- PASS: TestAccNewRelicMonitor_basic (271.76s)
--- PASS: TestAccNewRelicMonitor_requiresImport (285.08s)
--- PASS: TestAccNewRelicMonitor_complete (318.12s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/newrelic 345.954s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to update the test regions:

 Error: creating Monitor (Subscription: "*******"
        Resource Group Name: "acctest-rg-230613163328551874"
        Monitor Name: "acctest-nrm-230613163328551874"): performing CreateOrUpdate: unexpected status 400 with error: LocationNotAvailableForResourceType: The provided location 'eastus2' is not available for resource type 'NewRelic.Observability/monitors'. List of available regions for the resource type is 'eastus'.
        

website/docs/r/new_relic_monitor.html.markdown Outdated Show resolved Hide resolved
@ms-zhenhua
Copy link
Contributor Author

ms-zhenhua commented Jun 14, 2023

Looks like you'll need to update the test regions:

 Error: creating Monitor (Subscription: "*******"
        Resource Group Name: "acctest-rg-230613163328551874"
        Monitor Name: "acctest-nrm-230613163328551874"): performing CreateOrUpdate: unexpected status 400 with error: LocationNotAvailableForResourceType: The provided location 'eastus2' is not available for resource type 'NewRelic.Observability/monitors'. List of available regions for the resource type is 'eastus'.
        

Hi @katbyte, thank you for your review. I have limited the test region in setting.kt. I think it should take effect after merging into the main branch. I have also test it on TC with explicitly setting the region to eastus and all testcases passed.

@ms-zhenhua ms-zhenhua requested a review from katbyte June 14, 2023 06:17
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaks, LGTM 🌵

@ms-zhenhua
Copy link
Contributor Author

Hi @katbyte, just a reminder: I found the latest commit involving a change on kusto. I am not sure whether it's expected. Kindly help check. Thanks.

@katbyte katbyte merged commit e4ddeba into hashicorp:main Jun 21, 2023
@github-actions github-actions bot added this to the v3.62.0 milestone Jun 21, 2023
katbyte added a commit that referenced this pull request Jun 21, 2023
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request Jun 26, 2023
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request Jun 26, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants