Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: switching to Go 1.11 #2229

Merged
merged 2 commits into from
Nov 4, 2018
Merged

dependencies: switching to Go 1.11 #2229

merged 2 commits into from
Nov 4, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Upgrading / fixing the formatting required for us to move to Go 1.11

Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, really glad to see we upgrade to 1.11, which will make the testing work on my Windows. 👍

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit c05c4c6 into master Nov 4, 2018
@tombuildsstuff tombuildsstuff deleted the go-1.11 branch November 4, 2018 23:10
tombuildsstuff added a commit that referenced this pull request Nov 4, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants