azurerm_netapp_pool - update the validation of size_in_tb
#22943
Conversation
There was a problem hiding this comment.
Hi @neil-yechenwei - Thanks for this.
One question below, but otherwise looks good to me. If you can take a look, we should be able to get this merged.
Thanks!
| @@ -48,7 +48,7 @@ The following arguments are supported: | |||
|
|
|||
| * `service_level` - (Required) The service level of the file system. Valid values include `Premium`, `Standard`, or `Ultra`. Changing this forces a new resource to be created. | |||
|
|
|||
| * `size_in_tb` - (Required) Provisioned size of the pool in TB. Value must be between `4` and `500`. | |||
| * `size_in_tb` - (Required) Provisioned size of the pool in TB. Value must be between `2` and `500`. | |||
There was a problem hiding this comment.
Do we need to add a note here to clarify that this is a preview? (referencing the note on https://learn.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-set-up-capacity-pool)
|
@jackofallops , thanks for the comment. I updated PR. Please take another look. Thanks. |
There was a problem hiding this comment.
@neil-yechenwei, I had a look as well and left a single comment about the product link including the local of the documentation. If you could take a look that would be 🔥
| * `size_in_tb` - (Required) Provisioned size of the pool in TB. Value must be between `4` and `500`. | ||
| * `size_in_tb` - (Required) Provisioned size of the pool in TB. Value must be between `2` and `500`. | ||
|
|
||
| ~> **NOTE** `2` TB capacity pool sizing is currently in preview. You can only take advantage of the `2` TB minimum if all the volumes in the capacity pool are using `Standard` network features. If any volume is using `Basic` network features, the minimum size is `4` TB. See [here](https://learn.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-set-up-capacity-pool) for more information. |
There was a problem hiding this comment.
We should not include the locale (e.g., en-us) in the product link and allow the sites locale picker determine which locale the documentation should be served in.
| ~> **NOTE** `2` TB capacity pool sizing is currently in preview. You can only take advantage of the `2` TB minimum if all the volumes in the capacity pool are using `Standard` network features. If any volume is using `Basic` network features, the minimum size is `4` TB. See [here](https://learn.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-set-up-capacity-pool) for more information. | |
| ~> **NOTE** `2` TB capacity pool sizing is currently in preview. You can only take advantage of the `2` TB minimum if all the volumes in the capacity pool are using `Standard` network features. If any volume is using `Basic` network features, the minimum size is `4` TB. Please see the product [documentation](https://learn.microsoft.com/azure/azure-netapp-files/azure-netapp-files-set-up-capacity-pool) for more information. |
There was a problem hiding this comment.
Thanks. Updated.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fixes #22931