azurerm_linux/windows_virtual_machine_scale_set - cancel rolling upgrades before deleting resource
#22991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e from extensions resource
jackofallops
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Thanks @stephybun - One comment to address, otherwise LGTM 🐰
internal/services/compute/windows_virtual_machine_scale_set_resource_other_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
|
Tests looks good Last commit fixes the one failing test which was due to another copy pasta error in the test config. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #18973
This PR adds the functionality drafted in #18973 to the linux and windows VMSS.
I've intentionally omitted adding this to the extensions resource since it doesn't appear to be possible to configure rolling upgrades without specifying extensions in-line in the VMSS resource and setting extensions both in-line and with the extension resource causes diffs.
if there are issues with the deletion of extensions we can investigate and address this in a separate PR.