Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux/windows_virtual_machine_scale_set - cancel rolling upgrades before deleting resource #22991

Merged
merged 11 commits into from
Aug 18, 2023

Conversation

stephybun
Copy link
Member

Supersedes #18973

This PR adds the functionality drafted in #18973 to the linux and windows VMSS.

I've intentionally omitted adding this to the extensions resource since it doesn't appear to be possible to configure rolling upgrades without specifying extensions in-line in the VMSS resource and setting extensions both in-line and with the extension resource causes diffs.

if there are issues with the deletion of extensions we can investigate and address this in a separate PR.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - One comment to address, otherwise LGTM 🐰

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
@stephybun
Copy link
Member Author

Tests looks good
image

Last commit fixes the one failing test which was due to another copy pasta error in the test config.

@stephybun stephybun merged commit 98f5349 into main Aug 18, 2023
22 checks passed
@stephybun stephybun deleted the f/vmss-cancel-rolling-upgrade-before-deletion branch August 18, 2023 05:37
@github-actions github-actions bot added this to the v3.71.0 milestone Aug 18, 2023
stephybun added a commit that referenced this pull request Aug 18, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants