Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/api_management: support for sign_in, sign_up and policy blocks #3151

Merged
merged 4 commits into from
Apr 3, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds support for the sign_in and sign_up settings blocks - and also adds support for the policy block, which was previously added as a separate resource by @JunyiYi in #3145 (I've rolled this up into this PR since it's only possible to have one per API, thus it makes more sense within this resource).

This is the last PR from our list covered in #1177 - as such this fixed #1177

porting in the changes from #3145 into the APIM resource
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

azurerm/helpers/suppress/xml.go Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-04-03 at 10 27 00

@tombuildsstuff tombuildsstuff merged commit e1a8461 into master Apr 3, 2019
@tombuildsstuff tombuildsstuff deleted the f/api-management-enhancements branch April 3, 2019 08:32
tombuildsstuff added a commit that referenced this pull request Apr 3, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@cpdohert
Copy link

Forgive me if I'm not understanding something about API management policies here, but there are four different scopes for APIM policies: global, product, API and API operation. We make heavy use of product-scoped policies and I was hoping to make use of terraform for this now that the api_management resource has been merged - but it doesn't seem like there's any way to do that with the policy block as implemented. Also, if it's true that there can only be one policy per API, doesn't it make more sense for the policy {} block to be implemented in api_management_api than api_management? Implementing it in api_management would imply global policy scope.

@tombuildsstuff
Copy link
Contributor Author

@cpdohert this PR added support for Global Policies - we can look to add support for the other APIM policy resources but there’s no issue/feature request tracking them at the moment as far as I recall - would you mind opening a new issue for that?

@ghost
Copy link

ghost commented May 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: API Management support
3 participants