Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_container_group #333

Merged
merged 27 commits into from
Sep 14, 2017
Merged

New Resource: azurerm_container_group #333

merged 27 commits into from
Sep 14, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Sep 14, 2017

Re-opening PR #311 by @abhijeetgaiha - which I accidentally closed by force-pushing :(

Original description:


This has a basic implementation for #287 .

The following features are TBD:

  • Command lines
  • Volume Mounts
  • Environment Variables
  • Private container registries

Abhijeet Gaiha and others added 27 commits June 14, 2017 15:42
Merge branch 'master' of git://github.com/terraform-providers/terraform-provider-azurerm into terraform-providers-master

Conflicts:
	azurerm/provider.go
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Slack - I just quickly skimmed over it (and it looks good overall) as I'm assuming you did more thorough review in the linked PR.

@tombuildsstuff tombuildsstuff merged commit 69b4c49 into master Sep 14, 2017
@tombuildsstuff tombuildsstuff deleted the aci branch September 14, 2017 11:54
tombuildsstuff added a commit that referenced this pull request Sep 14, 2017
@tombuildsstuff
Copy link
Contributor Author

Just realised I didn't paste this in - Tests pass:

$ acctests azurerm TestAccAzureRMContainerGroup_
=== RUN   TestAccAzureRMContainerGroup_basicLinux
--- PASS: TestAccAzureRMContainerGroup_basicLinux (62.48s)
=== RUN   TestAccAzureRMContainerGroup_basicLinuxUpdate
--- PASS: TestAccAzureRMContainerGroup_basicLinuxUpdate (70.35s)
=== RUN   TestAccAzureRMContainerGroup_basicWindows
--- PASS: TestAccAzureRMContainerGroup_basicWindows (60.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	193.076s

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants