Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_sql_server #3513

Merged
merged 4 commits into from
May 26, 2019
Merged

New Data Source: azurerm_sql_server #3513

merged 4 commits into from
May 26, 2019

Conversation

alex-doerfler
Copy link
Contributor

Fixes #3512

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alex-doerfler! THis is off to a good start. I've left some comments inline and once they are addressed this should be good to merge

azurerm/data_source_sql_server.go Outdated Show resolved Hide resolved
azurerm/data_source_sql_server.go Outdated Show resolved Hide resolved
azurerm/data_source_sql_server.go Outdated Show resolved Hide resolved
azurerm/data_source_sql_server_test.go Outdated Show resolved Hide resolved
website/docs/d/sql_server.html.markdown Outdated Show resolved Hide resolved
azurerm/data_source_sql_server.go Show resolved Hide resolved
azurerm/data_source_sql_server.go Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @alex-doerfler

Thanks for pushing those changes - this now LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v1.30.0 milestone May 26, 2019
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-05-26 at 09 00 25

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review May 26, 2019 08:47

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 06da47c into hashicorp:master May 26, 2019
tombuildsstuff added a commit that referenced this pull request May 26, 2019
@ghost
Copy link

ghost commented Jun 20, 2019

This has been released in version 1.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SQL Server data source
3 participants