Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_platform_image #375

Merged
merged 1 commit into from
Sep 29, 2017
Merged

New Data Source: azurerm_platform_image #375

merged 1 commit into from
Sep 29, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Adding a Data Source for Platform Images, to be able to obtain the latest version number of a Platform Image

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMPlatformImage_basic
=== RUN   TestAccDataSourceAzureRMPlatformImage_basic
--- PASS: TestAccDataSourceAzureRMPlatformImage_basic (12.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	12.219s

mbfrahry
mbfrahry approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vancluever
vancluever approved these changes Sep 29, 2017
View reviewed changes
Copy link
Contributor

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 45d2cde into master Sep 29, 2017
@tombuildsstuff tombuildsstuff deleted the platform-images-data-source branch September 29, 2017 18:32
tombuildsstuff added a commit that referenced this pull request Sep 29, 2017
@tombuildsstuff
Updating to include #375
c71c2e9
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost unassigned vancluever Apr 1, 2020
@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vancluever vancluever vancluever approved these changes

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement new-data-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @mbfrahry @vancluever