Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_image #382

Merged
merged 1 commit into from
Oct 3, 2017
Merged

New Data Source: azurerm_image #382

merged 1 commit into from
Oct 3, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Added a new data source azurerm_image - fixes #371

Tests:

$  acctests azurerm TestAccDataSourceAzureRMImage_basic
=== RUN   TestAccDataSourceAzureRMImage_basic
--- PASS: TestAccDataSourceAzureRMImage_basic (504.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	504.387s

catsby
catsby approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vancluever
vancluever approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 64fc592 into master Oct 3, 2017
@tombuildsstuff tombuildsstuff deleted the data-source-image branch October 3, 2017 06:25
tombuildsstuff added a commit that referenced this pull request Oct 3, 2017
@tombuildsstuff
Updating to include #382
853797f
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vancluever vancluever vancluever approved these changes

@catsby catsby catsby approved these changes

@mbfrahry mbfrahry Awaiting requested review from mbfrahry

Assignees
No one assigned
Labels
enhancement new-data-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question/Req - Using a Packer image as a storage reference - Data Source?
3 participants
@tombuildsstuff @catsby @vancluever