Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring azurerm_subnet + New Data Source: azurerm_subnet #411

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Refactoring azurerm_subnet + New Data Source: azurerm_subnet #411

merged 2 commits into from
Oct 10, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Fixing an issue where it wasn't possible to remove a NSG / Route Table attachment

@tombuildsstuff
Refactoring Subnets
902dad0 
Fixing an issue where it wasn't possible to remove a NSG / Route Table attachment
@tombuildsstuff tombuildsstuff changed the title Refactoring azurerm_subnet Refactoring azurerm_subnet + New Data Source: azurerm_subnet Oct 10, 2017
@tombuildsstuff
Copy link
Contributor Author

Subnet tests pass:

$ acctests azurerm TestAccDataSourceAzureRMSubnet_
=== RUN   TestAccDataSourceAzureRMSubnet_basic
--- PASS: TestAccDataSourceAzureRMSubnet_basic (91.16s)
=== RUN   TestAccDataSourceAzureRMSubnet_networkSecurityGroup
--- PASS: TestAccDataSourceAzureRMSubnet_networkSecurityGroup (96.51s)
=== RUN   TestAccDataSourceAzureRMSubnet_routeTable
--- PASS: TestAccDataSourceAzureRMSubnet_routeTable (96.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	284.603s

@tombuildsstuff
Copy link
Contributor Author

Subnets tests pass:

screen shot 2017-10-10 at 19 09 10

mbfrahry
mbfrahry approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit eb93737 into master Oct 10, 2017
@tombuildsstuff tombuildsstuff deleted the subnets branch October 10, 2017 20:21
tombuildsstuff added a commit that referenced this pull request Oct 10, 2017
@tombuildsstuff
Updating to include #411
8512d93
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry