-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_client_config - add object_id
property
#4486
Conversation
azurerm/data_source_client_config.go
Outdated
"subscription_id": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
"service_principal_application_id": { | ||
|
||
"authenticated_object_id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this'd make more sense as object_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment about adding deprecated fields to the upgrade guide
|
||
--- | ||
|
||
~> **Note:** the following fields are only available when authenticating via a Service Principal (as opposed to using the Azure CLI): | ||
~> **Note:** the following fields are only available when authenticating via a Service Principal (as opposed to using the Azure CLI) and have been deprecated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add these deprecated fields to the Upgrade Guide for 2.0 https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/website/docs/guides/2.0-upgrade-guide.html.markdown if we haven't already
authenticated_object_id
property object_id
property
This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.35.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fixes #3234