-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added template validation #4715
Added template validation #4715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @itavy
Thanks for this PR - taking a look through this is looking good, if we can fix up the comments this otherwise LGTM 👍
Thanks!
e91a153
to
9c4a65f
Compare
Signed-off-by: Octavian Ionescu <itavyg@gmail.com>
9c4a65f
to
7020c0c
Compare
Signed-off-by: Octavian Ionescu <itavyg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ithParamsBody` test ``` $ acctests azurerm TestAccAzureRMTemplateDeployment_withParamsBody === RUN TestAccAzureRMTemplateDeployment_withParamsBody === PAUSE TestAccAzureRMTemplateDeployment_withParamsBody === CONT TestAccAzureRMTemplateDeployment_withParamsBody --- PASS: TestAccAzureRMTemplateDeployment_withParamsBody (523.09s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 523.141s ```
hey @itavy I've run the tests for this and aside from one existing failing test this LGTM: I hope you don't mind but to make that final test pass I've pushed a commit to this branch which changes the Thanks! |
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
if it is ok i will add a test for this case
Signed-off-by: Octavian Ionescu itavyg@gmail.com