Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_dns_zone #702

Merged
merged 2 commits into from
Jan 16, 2018
Merged

New Data Source: azurerm_dns_zone #702

merged 2 commits into from
Jan 16, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #694

@tombuildsstuff tombuildsstuff mentioned this pull request Jan 16, 2018
Closed
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMDNSZone_
=== RUN   TestAccDataSourceAzureRMDNSZone_basic
--- PASS: TestAccDataSourceAzureRMDNSZone_basic (262.35s)
=== RUN   TestAccDataSourceAzureRMDNSZone_tags
--- PASS: TestAccDataSourceAzureRMDNSZone_tags (220.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	483.238s

@tombuildsstuff tombuildsstuff added this to the 1.0.2 milestone Jan 16, 2018
paultyng
paultyng suggested changes Jan 16, 2018
View reviewed changes
azurerm/resource_arm_dns_zone_test.go Outdated
@@ -139,14 +139,14 @@ resource "azurerm_dns_zone" "test" {
name = "acctestzone%d.com"
resource_group_name = "${azurerm_resource_group.test.name}"
tags {
environment = "Production"
cost_center = "MSFT"
environment = "Production"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed tabs and spaces here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@tombuildsstuff tombuildsstuff removed the request for review from mbfrahry January 16, 2018 14:51
@tombuildsstuff tombuildsstuff merged commit 94f53b2 into master Jan 16, 2018
@tombuildsstuff tombuildsstuff deleted the dns-zone-data-source branch January 16, 2018 15:58
tombuildsstuff added a commit that referenced this pull request Jan 16, 2018
@tombuildsstuff
Updating to include #702
a78842a
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
new-data-source service/dns
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

New Data Source: Azure DNS Zone
2 participants
@tombuildsstuff @paultyng