Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appengine standard is missing basic and manual scaling #6052

Closed
wvanderdeijl opened this issue Apr 6, 2020 · 3 comments
Closed

appengine standard is missing basic and manual scaling #6052

wvanderdeijl opened this issue Apr 6, 2020 · 3 comments

Comments

@wvanderdeijl
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The Google AppEngine Standard resource is missing the options to specify automatic, basic or manual scaling and always uses automatic scaling.

The AppEngine Flex resource does have support for Automatic and Manual scaling (but no Basic as AppEngine Flex only allows Auto and Manual scaling), so hopefully this is mainly some copy/paste work from the AppEngine Flex resource to the AppEngine Standard resource.

With only automatic scaling for AppEngine Standard, we cannot create a Basic scaled appengine which is needed when handling serious Google Cloud Tasks. With Automatic scaling a task can only take 10 minutes, while a Basic scaled appengine is allowed upto 24 hrs execution time: https://cloud.google.com/appengine/docs/standard/nodejs/how-instances-are-managed

This makes Basic scaled AppEngine's suitable for a whole range of solutions where Automatic scaled AppEngine doesn't fit. However, it is a shame we cannot deploy Basis scalled AppEngine Standard with TF.

New or Affected Resource(s)

resource_app_engine_standard_app_version

Potential Terraform Configuration

I would assume this is very similar to the config for an AppEngine Flex.

References

API docs for Automatic Scaling (for AppEngine Flex and Standard): https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.services.versions#automaticscaling
API docs for Manual Scaling (for AppEngine Flex and Standard): https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.services.versions#manualscaling
API docs for Basic Scaling (for AppEngine Standard only): https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.services.versions#basicscaling

  • #0000
@ghost ghost added the enhancement label Apr 6, 2020
@wvanderdeijl wvanderdeijl changed the title appengine standard is missing appengine standard is missing basic and manual scaling Apr 6, 2020
@danawillow danawillow added this to the Goals milestone Apr 6, 2020
@wvanderdeijl
Copy link
Author

I tried to chip in and have created PR GoogleCloudPlatform/magic-modules#3373

@wvanderdeijl
Copy link
Author

My PR in magic-modules was merged and has no trickled down to this repo in #6183

@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants