Ignore "release: not found" error on helm_resource destroy #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbocinec
force-pushed
the
uninstall-ignore-not-found
branch
from
6047167
to
8a90b81
Compare
sbocinec
force-pushed
the
uninstall-ignore-not-found
branch
from
8a90b81
to
64847ff
Compare
sbocinec
changed the title
appilon
requested changes
Sep 20, 2024
helm/resource_release_test.go
Outdated
| @@ -1758,6 +1758,45 @@ func TestAccResourceRelease_delete_regression(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccResourceRelease_destroy_ignoreReleaseNotFoundError(t *testing.T) { | |||
There was a problem hiding this comment.
It's not really something we tend to test for let's remove the acceptance test and just go with the codechange. We will run the full suite of tests to ensure no regressions.
There was a problem hiding this comment.
okay, I have removed it
sbocinec
force-pushed
the
uninstall-ignore-not-found
branch
from
64847ff
to
e1fa892
Compare
|
I will add the changelog entry for you and get this merged |
appilon
approved these changes
Sep 24, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore "release: not found" error on helm_resource destroy to address GH-1488
Acceptance tests
Release Note
Release note for CHANGELOG:
References
helm uninstall --ignore-not-found#1488Community Note
Closes #1488