Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/kubernetes_service: Update external_ips correctly on K8S 1.8+ #127

Merged
merged 1 commit into from
Feb 27, 2018
Merged

resource/kubernetes_service: Update external_ips correctly on K8S 1.8+ #127

merged 1 commit into from
Feb 27, 2018

Conversation

radeksimko
Copy link
Member

This is mainly to address the following test failure:

=== RUN   TestAccKubernetesService_loadBalancer
--- FAIL: TestAccKubernetesService_loadBalancer (56.09s)
    testing.go:449: Step 1 error: Error applying: 1 error(s) occurred:
        
        * kubernetes_service.test: 1 error(s) occurred:
        
        * kubernetes_service.test: Failed to update service: jsonpatch replace operation does not apply: doc is missing key: /spec/deprecatedPublicIPs

Which occurs when testing against 1.8+.

@radeksimko radeksimko added the bug label Feb 27, 2018
@radeksimko radeksimko requested a review from a team February 27, 2018 13:25
@radeksimko radeksimko merged commit 9784f70 into master Feb 27, 2018
@radeksimko radeksimko deleted the b-svc-update-ext-ips branch February 27, 2018 21:31
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @paddycarver