Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub_path_expr to volume mount options #2622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jk-f5
Copy link

@jk-f5 jk-f5 commented Nov 16, 2024

Description

Added ability to declare sub_path_expr in volume mounts. I more or less just grepped for sub_path and added the equivalent code for sub_path_expr. I'm a bit shocked that this hasn't been added already.

Acceptance tests

  • Have you updated an existing acceptance tests for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS="-run '^TestAccKubernetes(Deployment|Pod|ReplicationController)'"
...
PASS

Release Note

Release note for CHANGELOG:

Enhancement
- Added ability to declare sub_path_expr in volume mounts. 

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jk-f5 jk-f5 requested a review from a team as a code owner November 16, 2024 00:32
Copy link

hashicorp-cla-app bot commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant