-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken links in docs #990
Comments
@dak1n1 I'd like to work on this issue. |
@neha-viswanathan That's great! Thanks for offering. The list above is probably still accurate, but here is a command that optionally could be used to get the current list of broken links, in case anything has changed: https://github.com/hashicorp/terraform-provider-kubernetes/blob/master/GNUmakefile#L129 You could uncomment that line and run |
@dak1n1 Hello Stef, There are several references of these links in the go code as well. Should I fix them too? |
@neha-viswanathan For the Go code, you might want to wait until this PR is merged. It touches most of the .go files since it's an SDK upgrade, which would mean potential merge conflicts. #1027 But after it's merged, you're welcome to fix as many links as you like! 😄 |
@neha-viswanathan Thanks for the PR! I just placed this issue into our queue so the next person on bug-duty can review it. (CC @jrhouston FYI) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
There are many broken links in the ./website directory. https://gist.githubusercontent.com/dak1n1/e71930a082cbaaef4137a5cc8749697a/raw/7b3ca8a6311c5419ee905fa07bb83620c42a9bc8/gistfile1.txt
Once those are fixed, the links check can be enabled. (See makefile).
Community Note
The text was updated successfully, but these errors were encountered: