`ValidatingAdmissionPolicy` resource support #2576

aayushsss1 · 2024-08-28T05:17:11Z

Description

Acceptance tests

Have you added an acceptance test for the functionality being added?
Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Closes #2250

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

BBBmau · 2024-08-29T17:23:41Z

Just a heads-up @aayushsss1 since we are currently working on migrating the provider over to the plugin framework we would actually prefer to have this be supported under plugin-framework instead of SDKv2. Let me know if you have any questions, thanks again for picking this up!

aayushsss1 · 2024-08-29T20:03:58Z

@BBBmau Understood! Is it very different compared to the earlier SDKv2?

BBBmau · 2024-08-29T20:43:29Z

@BBBmau Understood! Is it very different compared to the earlier SDKv2?

@aayushsss1 You'd want to include the resource in the internal/framework/provider directory.

You can see an example of how this is currently being tested on my fork here: https://github.com/BBBmau/terraform-provider-kubernetes/tree/add-codegen/internal/framework/provider

Some plugin-framework resource docs can also be found here: https://developer.hashicorp.com/terraform/plugin/framework/resources#add-resource-to-provider

While you work on it feel free to reach out for help!

aayushsss1 · 2024-09-05T13:17:05Z

@BBBmau Understood! Is it very different compared to the earlier SDKv2?

@aayushsss1 You'd want to include the resource in the internal/framework/provider directory.

You can see an example of how this is currently being tested on my fork here: https://github.com/BBBmau/terraform-provider-kubernetes/tree/add-codegen/internal/framework/provider

Some plugin-framework resource docs can also be found here: https://developer.hashicorp.com/terraform/plugin/framework/resources#add-resource-to-provider

While you work on it feel free to reach out for help!

@BBBmau I just have a small doubt, the metadata schema uses the earlier sdk v2, do I create a new separate metadata schema based on the plugin framework for the validating_admission_policy resource?

BBBmau · 2024-09-05T15:39:26Z

@BBBmau I just have a small doubt, the metadata schema uses the earlier sdk v2, do I create a new separate metadata schema based on the plugin framework for the validating_admission_policy resource?

@aayushsss1 I'm not sure what you're referring to when it comes to the earlier sdk v2, the metadata schema would be implemented the same as how we see it in the linked fork:
https://github.com/BBBmau/terraform-provider-kubernetes/blob/218df7e4bb7d233dd07b5053e089be75cd692f36/internal/framework/provider/appsv1/deployment_schema_gen.go#L25-L85

Let me know if the link answers your question, I could've missed something in regards to metadata schema uses the earlier sdkv2

aayushsss1 · 2024-09-05T16:21:54Z

@BBBmau I just have a small doubt, the metadata schema uses the earlier sdk v2, do I create a new separate metadata schema based on the plugin framework for the validating_admission_policy resource?

@aayushsss1 I'm not sure what you're referring to when it comes to the earlier sdk v2, the metadata schema would be implemented the same as how we see it in the linked fork: https://github.com/BBBmau/terraform-provider-kubernetes/blob/218df7e4bb7d233dd07b5053e089be75cd692f36/internal/framework/provider/appsv1/deployment_schema_gen.go#L25-L85

Let me know if the link answers your question, I could've missed something in regards to metadata schema uses the earlier sdkv2

Understood! I was referring to this earlier - https://github.com/hashicorp/terraform-provider-kubernetes/blob/main/kubernetes/schema_metadata.go

aayushsss1 · 2024-09-11T18:39:03Z

@BBBmau I've updated the schema in line with the plugin framework. Please have a look at the structure, and let me know if any changes have to be made, I'll get started with the crud and model in the mean time!

BBBmau · 2024-09-20T03:54:41Z

internal/framework/provider/appsv1/validating_admission_policy_schema_gen.go

+					},
+				},
+			},
+			"spec": schema.SingleNestedAttribute{


this looks to be good, I did notice that it's missing the status block, this can be seen from the api reference: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#validatingadmissionpolicy-v1-admissionregistration-k8s-io

Did you happen to use the code generation tool for this? Be sure to remove _gen from the end of all the files if you didn't use the generation tool.

I've renamed the files and I've added the status field!

BBBmau · 2024-09-20T03:55:15Z

go.mod

@@ -1,39 +1,39 @@
 module github.com/hashicorp/terraform-provider-kubernetes

-go 1.21


what's the reason for the change go.mod and go.sum?

@BBBmau I've reduced the number of changes to the go.mod, the main change is I've added the github.com/hashicorp/terraform-plugin-codegen-kubernetes/, which in turn has updated the plugin framework and other terraform dependencies.

ah the inclusion of github.com/hashicorp/terraform-plugin-codegen-kubernetes/ isn't necessary since it's a tool that you would install separately to help in generating plugin-framework resources.

You can go ahead and revert changes that came from adding it.

But isn't github.com/hashicorp/terraform-plugin-codegen-kubernetes/autocrud required for the CRUD operations?

I had to also utilize it here -

terraform-provider-kubernetes/internal/framework/provider/appsv1/validating_admission_policy.go

Lines 22 to 27 in 93654c5

type ValidatingAdmissionPolicy struct {

APIVersion string

Kind string

clientGetter autocrud.KubernetesClientGetter

}

ah yeah you're right. Apologies!

It's also worth noting that after reviewing the issue further that that once this PR is complete it unfortunately won't be merged until v3.0.0 due to this resource being supported by default in k8s 1.30. We intend to do a major version bump in order to support this since we currently only support up to v1.28. I've added it as part of v3..0.0 milestone as of now.

Of course you can still work on it but wanted to let you know in case you felt that this was on a deadline. We appreciate you working on this!

Sure, thanks for letting me know! If there are any other issues that require immediate attention I'd be glad to help out!

BBBmau · 2024-11-14T23:06:42Z

just a heads-up, we'll be working on v3 major release soon if you'd like to continue working on this. All we ask is that you rebase so that it's on v3-major-release branch

If not it's no worries!

aayushsss1 · 2024-11-15T16:08:07Z

@BBBmau I'll continue my work on this, thanks for the heads up!

…umeClaim handling

commit 095ee23cee2395859baef681f75331b88235aec4 Author: aayushsss1 <aayushsubramaniam@gmail.com> Date: Fri Nov 22 16:13:42 2024 -0500 updated go mod and sum commit 2de833a1cce9e27a8d981845c103d7b6374cf5ce Author: aayushsss1 <aayushsubramaniam@gmail.com> Date: Fri Nov 22 16:01:19 2024 -0500 changes reverted changelog updated updated changelog updated and rebased go mod updated commit 625c52a Author: aayushsss1 <aayushsubramaniam@gmail.com> Date: Fri Nov 22 16:08:43 2024 -0500 updated and rebased commit 50b0647 Author: aayushsss1 <aayushsubramaniam@gmail.com> Date: Fri Nov 22 16:07:30 2024 -0500 updated changelog commit 8fa05e2 Author: aayushsss1 <aayushsubramaniam@gmail.com> Date: Fri Nov 22 16:06:29 2024 -0500 changelog updated commit 9cbdc24 Author: aayushsss1 <aayushsubramaniam@gmail.com> Date: Fri Nov 22 16:01:19 2024 -0500 changes reverted

github-actions bot added the size/XL label Aug 28, 2024

BBBmau reviewed Sep 20, 2024

View reviewed changes

aayushsss1 force-pushed the validating-admission-policy branch from 1a3d8a5 to 93654c5 Compare September 23, 2024 20:05

BBBmau changed the base branch from main to v3-major-release November 15, 2024 17:50

aayushsss1 force-pushed the validating-admission-policy branch from 2eebbb1 to 5558ce2 Compare November 18, 2024 02:52

JaylonmcShan03 force-pushed the v3-major-release branch from 89a16b6 to e045752 Compare November 21, 2024 14:48

sheneska and others added 15 commits November 22, 2024 15:55

Upgrade kubernetes to v1.30.0

99f57a1

Upgrade dependencies

59c9c69

Upgrade dependencies & remove toolchain

41c24a1

upgrade Kubernetes Go client to v0.31.2 and Go version to 1.23

b33eefc

Remove deprecated PodSecurityPolicy resource and update PersistentVol…

b95be98

…umeClaim handling

schema added

7ad3598

schema updated

a47f4e7

updated schema to plugin framework

7043ad1

removed redundant schema

f606d1a

plugin framework updated

bd662b3

added model and crud

06961a1

updated client

df1b3ad

removed client

44c449e

added status field and updated go mod

f22e521

updated go mod

4e1cc33

updated go mod

f73a45a

aayushsss1 force-pushed the validating-admission-policy branch from b63e990 to f73a45a Compare November 22, 2024 20:59

aayushsss1 force-pushed the validating-admission-policy branch from 625c52a to f1fa992 Compare November 22, 2024 21:18

schema updated

2fd76a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`ValidatingAdmissionPolicy` resource support #2576

`ValidatingAdmissionPolicy` resource support #2576

aayushsss1 commented Aug 28, 2024

BBBmau commented Aug 29, 2024

aayushsss1 commented Aug 29, 2024

BBBmau commented Aug 29, 2024

aayushsss1 commented Sep 5, 2024

BBBmau commented Sep 5, 2024

aayushsss1 commented Sep 5, 2024

aayushsss1 commented Sep 11, 2024

BBBmau Sep 20, 2024

aayushsss1 Sep 23, 2024

BBBmau Sep 20, 2024

aayushsss1 Sep 23, 2024

BBBmau Sep 23, 2024

aayushsss1 Sep 23, 2024

BBBmau Sep 25, 2024

aayushsss1 Sep 25, 2024

BBBmau commented Nov 14, 2024

aayushsss1 commented Nov 15, 2024

		@@ -1,39 +1,39 @@
		module github.com/hashicorp/terraform-provider-kubernetes

		go 1.21

	type ValidatingAdmissionPolicy struct {
	APIVersion string
	Kind string

	clientGetter autocrud.KubernetesClientGetter
	}

ValidatingAdmissionPolicy resource support #2576

Are you sure you want to change the base?

ValidatingAdmissionPolicy resource support #2576

Conversation

aayushsss1 commented Aug 28, 2024

Description

Acceptance tests

Release Note

References

Community Note

BBBmau commented Aug 29, 2024

aayushsss1 commented Aug 29, 2024

BBBmau commented Aug 29, 2024

aayushsss1 commented Sep 5, 2024

BBBmau commented Sep 5, 2024

aayushsss1 commented Sep 5, 2024

aayushsss1 commented Sep 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BBBmau commented Nov 14, 2024

aayushsss1 commented Nov 15, 2024

`ValidatingAdmissionPolicy` resource support #2576

`ValidatingAdmissionPolicy` resource support #2576