Allow underscore in database_name [redshift]

[sharmaansh21]

Fixes #10009

[stack72]

Hi @optimisticanshul

Thanks for the work here - please can you add a test that covers the different use cases? You can use iam_user name validation as an example

Thanks

Paul

[sharmaansh21]

anssharma@Ban-1Anssharma-M:~/Code/go/src/github.com/hashicorp/terraform|patch-2
⇒  make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestValidateRedshiftClusterDbName'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/10 18:50:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestValidateRedshiftClusterDbName -timeout 120m
=== RUN   TestValidateRedshiftClusterDbName
--- PASS: TestValidateRedshiftClusterDbName (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    5.586s

anssharma@Ban-1Anssharma-M:~/Code/go/src/github.com/hashicorp/terraform|patch-2
⇒  make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/10 18:52:16 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster_ -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_importBasic
--- PASS: TestAccAWSRedshiftCluster_importBasic (601.34s)

[sharmaansh21]

@stack72 Ready for another review.

[stack72]

Hi @optimisticanshul

1 last addition please - can you readd back in the failing test cases for too long and empty string? :)

Thanks

[sharmaansh21]

@stack72 👍

[stack72]

Thanks for all the work here @optimisticanshul :)

LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.