provider/docker: Add network create --internal flag support

[lvjp]

Add support for the --internal flag of the docker command docker network create

[stack72]

Hi @lvjp

Thanks for the work here - please can you add an acceptance test to show that this takes affect? That would help us push this change through faster

Thanks

Paul

[stack72]

Acceptance test has been requested :)

[lvjp]

You was right, acceptance test was needed !

[stack72]

Hi @lvjp

This LGTM now - thanks for adding the test and proving that both systems work as expected :)

% make testacc TEST=./builtin/providers/docker
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/03 11:40:36 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/docker -v  -timeout 120m
=== RUN   TestAccDockerRegistryImage_basic
--- PASS: TestAccDockerRegistryImage_basic (6.54s)
=== RUN   TestAccDockerRegistryImage_private
--- PASS: TestAccDockerRegistryImage_private (1.94s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDockerContainer_basic
--- PASS: TestAccDockerContainer_basic (19.87s)
=== RUN   TestAccDockerContainer_volume
--- PASS: TestAccDockerContainer_volume (80.81s)
=== RUN   TestAccDockerContainer_customized
--- PASS: TestAccDockerContainer_customized (32.17s)
=== RUN   TestAccDockerContainer_upload
--- PASS: TestAccDockerContainer_upload (20.52s)
=== RUN   TestAccDockerImage_basic
--- PASS: TestAccDockerImage_basic (6.13s)
=== RUN   TestAccDockerImage_private
--- PASS: TestAccDockerImage_private (2.38s)
=== RUN   TestAccDockerImage_destroy
--- PASS: TestAccDockerImage_destroy (0.27s)
=== RUN   TestAccDockerImage_data
--- PASS: TestAccDockerImage_data (8.59s)
=== RUN   TestAccDockerNetwork_basic
--- PASS: TestAccDockerNetwork_basic (0.41s)
=== RUN   TestAccDockerNetwork_internal
--- PASS: TestAccDockerNetwork_internal (0.28s)
=== RUN   TestAccDockerVolume_basic
--- PASS: TestAccDockerVolume_basic (0.23s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/docker	180.190s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.