Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows locks #12059

Merged
merged 2 commits into from
Feb 17, 2017
Merged

fix windows locks #12059

merged 2 commits into from
Feb 17, 2017

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Feb 17, 2017

Don't create a second windows handle for the lock file.
Fixes #12012

Don't create a new windows handle for the lock.
delete(lockedFiles, s.stateFileOut)
return syscall.Close(handle)
// the file is closed in Unlock
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? We are unlocked automatically on file close? When does that happen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, file is unocked when the associated handle is closed. This happens automatically when Close is called in the main Unlock method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Looks great!

@jbardin jbardin merged commit 3f13a26 into master Feb 17, 2017
@jbardin jbardin deleted the jbardin/windows-locks branch February 17, 2017 20:46
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform init fails on windows (v0.9.0-beta1)
2 participants