provider/aws: fix aws_route53_zone force_destroy behavior

[ryane]

The conditional to ignore the deletion of NS and SOA records can fail to
match if the hostedZoneName already ends with a ".". When that happens,
terraform tries to delete those records which is not supported by AWS
and results in a 400 bad request. This fixes the conditional so that it
will work whether or not hostedZoneName ends with a ".".

fixes #12407

[radeksimko]

Hi @ryane
this is useful bugfix, thanks.

I appreciate the test modification to cover the fixed behaviour. It would be better if we covered both cases though - with and without trailing dot, to make sure we don't introduce a similar bug in the future that would break zones w/out dot.

I will send a separate patch to reflect this.

---

FYI: For future contributions it usually helps both the reviewer and yourself (I think 😃 ) when the PR is raised from a separate branch - not master. It's much easier to make any necessary changes without having to force-push into master and it allows you to raise multiple different PRs in isolation. 😉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.