Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of network ACL default IPv6 ingress/egress rules #12835

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Correct handling of network ACL default IPv6 ingress/egress rules #12835

merged 1 commit into from
Mar 27, 2017

Conversation

ewbankkit
Copy link
Contributor

Fixes #12831.

  • Handle IPv6 default rules the same as IPv4 default rules
  • A NACL only has IPv6 default rules if the associated VPC has an IPv6 CIDR block, so in the aws_default_network_acl resource acceptance tests make the number of hidden rules a variable

Acceptance tests:

make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSDefaultNetworkAcl_basicIpv6Vpc'
make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSNetworkAcl_ipv6VpcRules'

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for picking this up - sorry i didn't add this when i added the IPv6 work

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDefaultNetworkAcl_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/25 23:28:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basic
--- PASS: TestAccAWSDefaultNetworkAcl_basic (50.56s)
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (36.87s)
=== RUN   TestAccAWSDefaultNetworkAcl_deny_ingress
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (51.55s)
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetRemoval
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (92.68s)
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (109.93s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	341.606s

@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/aws aws_network_acl resource incorrectly handling default IPv6 ingress/egress rules
3 participants