Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name_prefix to aws_alb_target_group #13442

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Add name_prefix to aws_alb_target_group #13442

merged 1 commit into from
Apr 7, 2017

Conversation

joshuaspence
Copy link
Contributor

Adds the name_prefix parameter to the aws_alb_target_group resource.

@joshuaspence
Add name_prefix to aws_alb_target_group
05d7b1e 
Adds the `name_prefix` parameter to the `aws_alb_target_group` resource.
catsby
catsby approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question/request for docs, other than that 👍

website/source/docs/providers/aws/r/alb_target_group.html.markdown
@@ -31,7 +31,8 @@ resource "aws_vpc" "main" {

The following arguments are supported:

* `name` - (Required) The name of the target group.
* `name` - (Optional, Forces new resource) The name of the target group. If omitted, Terraform will assign a random, unique name.
* `name_prefix` - (Optional, Forces new resource) Creates a unique name beginning with the specified prefix. Conflicts with `name`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include the character limits here in the documentation? Also, why the 6 character limit for the prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 6 character limit is because name_prefix generates 26 characters of randomness and the maximum length for the name imposed by AWS is 32 characters. See #12947.

@stack72
Copy link
Contributor

stack72 commented Apr 7, 2017

LGTM thanks :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALBTargetGroup_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/07 17:43:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSALBTargetGroup_basic
--- PASS: TestAccAWSALBTargetGroup_basic (57.68s)
=== RUN   TestAccAWSALBTargetGroup_namePrefix
--- PASS: TestAccAWSALBTargetGroup_namePrefix (79.98s)
=== RUN   TestAccAWSALBTargetGroup_generatedName
--- PASS: TestAccAWSALBTargetGroup_generatedName (58.31s)
=== RUN   TestAccAWSALBTargetGroup_changeNameForceNew
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (151.63s)
=== RUN   TestAccAWSALBTargetGroup_changeProtocolForceNew
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (113.76s)
=== RUN   TestAccAWSALBTargetGroup_changePortForceNew
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (133.12s)
=== RUN   TestAccAWSALBTargetGroup_changeVpcForceNew
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (135.78s)
=== RUN   TestAccAWSALBTargetGroup_tags
--- PASS: TestAccAWSALBTargetGroup_tags (109.89s)
=== RUN   TestAccAWSALBTargetGroup_updateHealthCheck
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (106.24s)
=== RUN   TestAccAWSALBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (142.06s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	1088.476s

@stack72 stack72 merged commit 488711a into hashicorp:master Apr 7, 2017
@joshuaspence joshuaspence deleted the alb_target_group-name_prefix branch April 11, 2017 07:32
ashb
ashb reviewed May 24, 2017
View reviewed changes
builtin/providers/aws/validators.go

func validateAwsAlbTargetGroupNamePrefix(v interface{}, k string) (ws []string, errors []error) {
name := v.(string)
if len(name) > 32 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 6, not 32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ashb - what makes you think it should be 6?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the message on the next line says 6! (I came here because I got this error upon trying name_prefix:

  • aws_alb_target_group.mod: Error creating ALB Target Group: ValidationError: Target group name 'ash-test-airflow-webserver0019dc824d8cf5fe93abbb8785' cannot be longer than '32' characters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the discussion https://github.com/hashicorp/terraform/pull/13442/files#r110410247

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stack72 stack72 stack72 left review comments

@ashb ashb ashb left review comments

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshuaspence @stack72 @ashb @catsby @radeksimko