-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/azurerm: VM Scale Sets - import support + fixes #13464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(leaving a null entry at the start, causing a crash on the second apply)
bfd2e48
to
569841c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tests pass:
|
Making custom_data a force new, since it an't be updated
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes several issues with VM Scale Sets:
ssh_keys
state field, causing a crash on the next apply, which fixes: make apply crashes #13094 azure_virtual_mashine_scale_set: crash after apply on created environment #13009custom_data
in the state file as base64custom_data
ForceNew, since it's not possible to update it