Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to google_pubsub_subscription #14238

Merged

Conversation

dasch
Copy link
Contributor

@dasch dasch commented May 5, 2017

The path is used to globally identify a subscription. Specifically, I need to pass the path to a Dataflow job.

The path is used to globally identify a subscription.
@stack72
Copy link
Contributor

stack72 commented May 5, 2017

Hi @dasch

Thanks for the work here - I added the documentation and updated the test for this locally to prove that all was working

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccPubsubSubscription'           ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/05 15:55:30 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccPubsubSubscription -timeout 120m
=== RUN   TestAccPubsubSubscriptionCreate
--- PASS: TestAccPubsubSubscriptionCreate (11.62s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	11.639s

Thanks for the work here

Paul

@stack72 stack72 merged commit 67e9949 into hashicorp:master May 5, 2017
@dasch
Copy link
Contributor Author

dasch commented May 5, 2017

👍

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants