providers/heroku: import heroku_app resource

[bernerdschaefer]

Adds support for importing normal and organization apps with the heroku_app resource.

The resource itself depends on an organization value in the configuration to switch behavior for the different kinds of apps, so schema.ImportStatePassthrough is not sufficient.

Resolves #12087.

[bernerdschaefer]

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/05 11:07:56 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/heroku -v  -timeout 120m
=== RUN   TestAccHerokuApp_importBasic
--- PASS: TestAccHerokuApp_importBasic (7.32s)
=== RUN   TestAccHerokuApp_importOrganization
--- PASS: TestAccHerokuApp_importOrganization (4.81s)
...

[stack72]

Hi @bernerdschaefer

Thanks for the work here - this LGTM! Just got the faling spaces tests that we had before

% make testacc TEST=./builtin/providers/heroku                                                                            2 ↵ ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/05 22:23:41 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/heroku -v  -timeout 120m
=== RUN   TestAccHerokuApp_importBasic
--- PASS: TestAccHerokuApp_importBasic (4.54s)
=== RUN   TestAccHerokuApp_importOrganization
--- PASS: TestAccHerokuApp_importOrganization (4.55s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccHerokuAddon_Basic
--- PASS: TestAccHerokuAddon_Basic (5.41s)
=== RUN   TestAccHerokuAddon_noPlan
--- PASS: TestAccHerokuAddon_noPlan (7.55s)
=== RUN   TestAccHerokuAppFeature
--- PASS: TestAccHerokuAppFeature (7.79s)
=== RUN   TestAccHerokuApp_Basic
--- PASS: TestAccHerokuApp_Basic (4.33s)
=== RUN   TestAccHerokuApp_NameChange
--- PASS: TestAccHerokuApp_NameChange (7.99s)
=== RUN   TestAccHerokuApp_NukeVars
--- PASS: TestAccHerokuApp_NukeVars (6.80s)
=== RUN   TestAccHerokuApp_Buildpacks
--- PASS: TestAccHerokuApp_Buildpacks (9.53s)
=== RUN   TestAccHerokuApp_ExternallySetBuildpacks
--- PASS: TestAccHerokuApp_ExternallySetBuildpacks (5.58s)
=== RUN   TestAccHerokuApp_Organization
--- PASS: TestAccHerokuApp_Organization (4.04s)
=== RUN   TestAccHerokuApp_Space
--- SKIP: TestAccHerokuApp_Space (0.00s)
	resource_heroku_app_test.go:220: HEROKU_SPACE is not set; skipping test.
=== RUN   TestAccHerokuCert_Basic
--- PASS: TestAccHerokuCert_Basic (18.11s)
=== RUN   TestAccHerokuDomain_Basic
--- PASS: TestAccHerokuDomain_Basic (5.10s)
=== RUN   TestAccHerokuDrain_Basic
--- PASS: TestAccHerokuDrain_Basic (4.87s)
=== RUN   TestAccHerokuPipelineCoupling_Basic
--- PASS: TestAccHerokuPipelineCoupling_Basic (6.53s)
=== RUN   TestAccHerokuPipeline_Basic
--- PASS: TestAccHerokuPipeline_Basic (3.18s)
=== RUN   TestAccHerokuSpace_Basic
--- FAIL: TestAccHerokuSpace_Basic (0.23s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* heroku_space.foobar: 1 error(s) occurred:

		* heroku_space.foobar: Post https://api.heroku.com/spaces: Space management is not enabled for this team.
=== RUN   TestPipelineStage
--- PASS: TestPipelineStage (0.00s)
=== RUN   TestValidateUUID
--- PASS: TestValidateUUID (0.00s)
FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/heroku	106.169s
make: *** [testacc] Error 1

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.