Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed method on aggregator is avg ! average #14414

Merged
merged 3 commits into from
May 12, 2017
Merged

Allowed method on aggregator is avg ! average #14414

merged 3 commits into from
May 12, 2017

Conversation

dthagard
Copy link
Contributor

While Datadog will accept the value of average when creating the query graph, the resultant graph will be empty. Passing the value of avg instead correctly renders the graph.

Graph with average:
image

Graph with avg:
image

dthagard added 2 commits May 11, 2017 17:12
While Datadog will accept the value of `average` when creating the query graph, the resultant graph will be empty. Passing the value of `avg` instead correctly renders the graph.
@grubernaut
Copy link
Contributor

Hey @dthagard, thanks for the submission!

Looks like the unit test just needs to be updated to fix the CI tests:

--- FAIL: TestValidateAggregatorMethod (0.00s)
	resource_datadog_timeboard_test.go:235: "average" should be a valid aggregator method: ["\"request\" contains an invalid method \"average\". Valid methods are either \"avg\", \"max\", \"min\", \"sum\", or \"last\""]

@stack72
Copy link
Contributor

stack72 commented May 12, 2017

LGTM! Thanks for this :)

@stack72 stack72 merged commit 0a37f35 into hashicorp:master May 12, 2017
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants