Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct to and from backends when migrating #15318

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

duckpuppy
Copy link
Contributor

@duckpuppy duckpuppy commented Jun 16, 2017

Fixes #15306

Display correct to and from backends in copy message when
migrating to new remote state

There are no existing tests I can find that test output of messages. Is that
something desirable to test?

@jbardin
Copy link
Member

jbardin commented Jun 22, 2017

Hi @duckpuppy,

Thanks for catching this.

Sorry, I didn't notice you were waiting for feedback on the tests. While I think it would be nice to have tests around this, testing that output would be a much larger task. Visually inspecting all the ui confirmation sites, it appears that this was the only one which was mismatched.

@jbardin
Copy link
Member

jbardin commented Jun 23, 2017

@duckpuppy: I just want to check that you don't have any pending concerns with this change, since there is a [WIP] still on it.

@duckpuppy
Copy link
Contributor Author

@jbardin Sorry, didn't see the feedback until just now. I'll remove the WIP from the title. No other concerns.

@duckpuppy duckpuppy changed the title [WIP] Correct to and from backends when migrating Correct to and from backends when migrating Jun 24, 2017
@stack72 stack72 merged commit 7775ef8 into hashicorp:master Jun 27, 2017
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State migration message seems backwards
4 participants