Terraform destroy fails "variable ... is nil, but no error was reported" #18197

angelzamir · 2018-06-06T17:25:50Z

Terraform version:

Terraform v0.11.7
+ provider.external v1.0.0
+ provider.google v1.13.0
+ provider.null v1.0.0
+ provider.random v1.3.1

Hello, I'm having trouble with a module, it does the following:

1. Creates gcp project
1. Downloads a git repo (depends on 1)
1. Executes 1 command with a null provider (depends on 2)
1. Executes a external data source (depends on 3)

Module's resources are:

resource "google_project" "project" {
  name            = "${var.project_name}"
  project_id      = "${local.temp_project_id}"
  org_id          = "${var.organization_id}"
  folder_id       = "${var.folder_id}"
  billing_account = "${var.billing_account}"

  labels = "${var.project_labels}"
}

resource "null_resource" "get_repo" {
  count = "${var.download_repo == true ? 1 : 0}"

  provisioner "local-exec" {
    command = "git clone --single-branch -b ${var.repo_b} ${var.repo_url}"
  }

  depends_on = ["google_project.project"]
}

resource "null_resource" "execute_command" {
  provisioner "local-exec" {
    command = "echo ${google_project.project.project_id}"
  }
  depends_on = ["null_resource.get_repo"]
}

data "external" "bucket_retrieval" {
  program = ["bash", "${path.module}/scripts/get-project-buckets.sh", "${var.credentials_file_path}"]

  depends_on = ["null_resource.execute_command"]
}

Module's outputs are:

output "project_id" {
  value       = "${google_project.project.project_id}"
  description = "The project's id"
}

output "buckets_list" {
  value       = "${compact(split(" ", data.external.bucket_retrieval.result["buckets_list"]))}"
  description = "The buckets list within the created project"
}

The outputs.tf where I call the module is as follows:

output "project_id" {
  value = "${module.install-simple.project_id}"
}

output "buckets_list" {
  value = "${module.install-simple.buckets_list}"
}

Steps:

terraform plan and terraform apply steps work well
terraform destroy at first time fails and the output is:

[root@localhost simple]# terraform destroy -force -var-file=variables.tfvariables 
random_id.random_project_id_suffix: Refreshing state... (ID: lf0)
google_project.project: Refreshing state... (ID: terraform-test-95fd)
null_resource.execute_command: Refreshing state... (ID: 8745349763456357012)
module.install-simple.null_resource.execute_command: Destroying... (ID: 8745349763456357012)
module.install-simple.null_resource.execute_command: Destruction complete after 0s
module.install-simple.google_project.project: Destroying... (ID: terraform-test-95fd)
module.install-simple.google_project.project: Destruction complete after 3s
module.install-simple.random_id.random_project_id_suffix: Destroying... (ID: lf0)
module.install-simple.random_id.random_project_id_suffix: Destruction complete after 0s

Error: Error applying plan:

1 error(s) occurred:

* module.install-simple.output.buckets_list: Resource 'data.external.bucket_retrieval' does not have attribute 'result' for variable 'data.external.bucket_retrieval.result'

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

Then when I try to perform terraform destroy again, the output changes but error remains:

Error: Error applying plan:

2 error(s) occurred:

* module.install-simple.output.project_id: variable "project" is nil, but no error was reported
* module.install-simple.output.buckets_list: variable "bucket_retrieval" is nil, but no error was reported

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

Note: the external data source script always returns a json like:

{
  "buckets_list": " "
}

or with contents on the property

{
  "buckets_list": "bucket1 bucket2 bucket3"
}

Thanks!

The text was updated successfully, but these errors were encountered:

morgante · 2018-06-06T20:56:48Z

It looks like depending on an external data source will cause errors during destroy. Could we make a simple test case to demonstrate this?

angelzamir · 2018-06-06T21:21:30Z

Sure.

/module/main.tf

resource "null_resource" "execute_command" {
  provisioner "local-exec" {
    command = "echo hi"
  }
}

data "external" "external" {
  program = ["jq", "-n", "{\"buckets_list\" : \" \"}"]

  depends_on = ["null_resource.execute_command"]
}

output "output" {
  value = "${data.external.external.result["buckets_list"]}"
}

/main.tf

module "module" {
  source = "module"
}

output "output_f_module" {
  value = "${module.module.output}"
}

First destroy:

[root@localhost bug]# terraform destroy -force
null_resource.execute_command: Refreshing state... (ID: 2995243002782748572)
module.module.null_resource.execute_command: Destroying... (ID: 2995243002782748572)
module.module.null_resource.execute_command: Destruction complete after 0s

Error: Error applying plan:

1 error(s) occurred:

* module.module.output.output: Resource 'data.external.external' does not have attribute 'result' for variable 'data.external.external.result'

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

Second destroy:

[root@localhost bug]# terraform destroy -force

Error: Error applying plan:

1 error(s) occurred:

* module.module.output.output: variable "external" is nil, but no error was reported

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

jbardin · 2018-06-07T21:42:03Z

Hi @angelzamir,

Thanks for filing the issue. This is essentially the same as #17862, but I'll leave this open as a reminder that it applies to variables too.

Horgix · 2018-07-16T09:58:02Z

Just encountered this as well, just to add to the report:

Versions:

Terraform v0.11.7
+ provider.google v1.16.0

Errors:

* module.foobar.module.deployment-project.output.ci-service-account-email: variable "ci_service_account" is nil, but no error was reported
* module.foobar.output.folder: variable "folder" is nil, but no error was reported
* module.foobar.module.deployment-project.output.terraform-service-account-email: variable "terraform_service_account" is nil, but no error was reported

alexaandru · 2018-07-31T13:57:11Z

Running into this as well, when destroying an aws bucket (that was also created by TF).

Versions:

Terraform v0.11.7

provider.aws v1.28.0

The bucket is created in a module, with SSE, and a couple of locals for the bucket name and the SSE kind, and a bucket policy. Creation works as expected, destructions fails every time with the same error as above:

module.x_bucket.output.arn: variable "b" is nil, but no error was reported

module.y_bucket.output.arn: variable "b" is nil, but no error was reported

Even though destruction fails, the buckets are actually gone from AWS, so it does work as intended, it errors out for no apparent reason.

bernadinm · 2018-09-24T19:06:58Z

This also affects this version as well:

$ terraform -v
Terraform v0.11.8
+ provider.google v1.18.0

securityclippy · 2018-11-01T03:39:11Z

still present in v0.11.10.

aaomoware · 2018-11-15T11:54:20Z

While export TF_WARN_OUTPUT_ERRORS=1 does suppress this bug, it'd be nice to have this issue addressed.

Without suppression

➜  K8SonAWS git:(master) ✗ terraform destroy --force
data.aws_availability_zones.azones: Refreshing state...
data.aws_region.region: Refreshing state...
data.aws_iam_policy_document.eks_wn_role_policy: Refreshing state...
data.aws_ami.eks_ami: Refreshing state...
data.aws_iam_policy_document.eks_mc_role_policy: Refreshing state...

Error: Error applying plan:

2 error(s) occurred:

* module.eks_cluster.output.certificate_authority_data: variable "ec" is nil, but no error was reported
* module.eks_cluster.output.endpoint: variable "ec" is nil, but no error was reported

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.


➜  K8SonAWS git:(master) ✗ terraform --version      
Terraform v0.11.10
+ provider.aws v1.45.0
+ provider.local v1.1.0

➜  K8SonAWS git:(master) ✗

With suppression

➜  K8SonAWS git:(master) ✗ export TF_WARN_OUTPUT_ERRORS=1
➜  K8SonAWS git:(master) ✗ terraform --version           
Terraform v0.11.10
+ provider.aws v1.45.0
+ provider.local v1.1.0

➜  K8SonAWS git:(master) ✗ terraform destroy --force     
data.aws_availability_zones.azones: Refreshing state...
data.aws_region.region: Refreshing state...
data.aws_ami.eks_ami: Refreshing state...
data.aws_iam_policy_document.eks_wn_role_policy: Refreshing state...
data.aws_iam_policy_document.eks_mc_role_policy: Refreshing state...

Destroy complete! Resources: 0 destroyed.
➜  K8SonAWS git:(master) ✗

ozbillwang · 2019-06-05T07:19:55Z

Thanks, @aaomoware

TF_WARN_OUTPUT_ERRORS=1 get rid of the warning and destroy is successful.

git4raj · 2019-06-05T17:25:02Z

Yes, this bug exists in v0.11.11. The work around of setting
export TF_WARN_OUTPUT_ERRORS=1 helps.

dohoangkhiem · 2019-06-26T03:33:27Z

happened in v0.11.14. I would not use the export of TF_WARN_OUTPUT_ERRORS as a proper fix. Tbh the error message looks also very un-meaningful (an error which says "no error was reported"?!), and not be able to destroy an empty tf state is really bad

ubuntu@ip-172-31-15-42:~/temp$ terraform state list 
ubuntu@ip-172-31-15-42:~/temp$ terraform destroy -force

Error: Error applying plan:

1 error occurred:
	* module.test.output.customer_sec_group: variable "customer_security_group" is nil, but no error was reported

jbardin · 2019-12-10T21:10:31Z

I verified that once updated to 0.12, the examples here no longer present an error.
Since there is no further development for 0.11 releases, we can close this out.

ghost · 2020-03-28T02:05:56Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jbardin added bug core labels Jun 7, 2018

apparentlymart added config and removed core labels Nov 8, 2018

aaron-lane mentioned this issue Nov 30, 2018

kitchen-terraform destroy empty tf workspace - error newcontext-oss/kitchen-terraform#289

Closed

hashibot added the v0.11 Issues (primarily bugs) reported against v0.11 releases label Aug 22, 2019

jbardin closed this as completed Dec 10, 2019

ghost locked and limited conversation to collaborators Mar 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform destroy fails "variable ... is nil, but no error was reported" #18197

Terraform destroy fails "variable ... is nil, but no error was reported" #18197

angelzamir commented Jun 6, 2018

morgante commented Jun 6, 2018

angelzamir commented Jun 6, 2018

jbardin commented Jun 7, 2018

Horgix commented Jul 16, 2018 •

edited

Loading

alexaandru commented Jul 31, 2018

bernadinm commented Sep 24, 2018

securityclippy commented Nov 1, 2018

aaomoware commented Nov 15, 2018 •

edited

Loading

ozbillwang commented Jun 5, 2019

git4raj commented Jun 5, 2019

dohoangkhiem commented Jun 26, 2019

jbardin commented Dec 10, 2019

ghost commented Mar 28, 2020

Terraform destroy fails "variable ... is nil, but no error was reported" #18197

Terraform destroy fails "variable ... is nil, but no error was reported" #18197

Comments

angelzamir commented Jun 6, 2018

Module's resources are:

Module's outputs are:

The outputs.tf where I call the module is as follows:

Steps:

Note: the external data source script always returns a json like:

or with contents on the property

morgante commented Jun 6, 2018

angelzamir commented Jun 6, 2018

/module/main.tf

/main.tf

First destroy:

Second destroy:

jbardin commented Jun 7, 2018

Horgix commented Jul 16, 2018 • edited Loading

alexaandru commented Jul 31, 2018

bernadinm commented Sep 24, 2018

securityclippy commented Nov 1, 2018

aaomoware commented Nov 15, 2018 • edited Loading

ozbillwang commented Jun 5, 2019

git4raj commented Jun 5, 2019

dohoangkhiem commented Jun 26, 2019

jbardin commented Dec 10, 2019

ghost commented Mar 28, 2020

Horgix commented Jul 16, 2018 •

edited

Loading

aaomoware commented Nov 15, 2018 •

edited

Loading