Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS Deletion Protection #18985

Closed
nomeelnoj opened this issue Oct 3, 2018 · 3 comments
Closed

RDS Deletion Protection #18985

nomeelnoj opened this issue Oct 3, 2018 · 3 comments

Comments

@nomeelnoj
Copy link

Current Terraform Version

Terraform v0.11.8

Use-cases

Some companies have trigger happy users, and it would be nice to protect against them by being able to turn on deletion protection for RDS

Attempted Solutions

None

Proposal

Allow terraform users to enable deletion protection. If using terraform to also delete the instance, there could be a "force" command or a user prompt to verify if deletion protection is turned on. If force is true or the user accepts, terraform could turn off deletion protection before destroying. This option is available in the CLI with modify-db-instance [--deletion-protection | --no-deletion-protection]

@kevlened
Copy link

kevlened commented Oct 3, 2018

I believe prevent_destroy under the lifecycle meta-parameter should prevent deletion. To override it, use a ternary operator on a variable you pass into the configuration.

edit: I see. This is a new AWS feature to prevent deletion, even outside of Terraform.

@bflad
Copy link
Contributor

bflad commented Oct 4, 2018

Support for the new deletion_protection argument was handled in the AWS provider via:

Which were both released yesterday with version 1.39.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad closed this as completed Oct 4, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants