Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper/acctest: RandIntRange should return integers within the range of min...max #171

Closed
teamterraform opened this issue Aug 8, 2019 · 2 comments · Fixed by #300
Closed

helper/acctest: RandIntRange should return integers within the range of min...max #171

teamterraform opened this issue Aug 8, 2019 · 2 comments · Fixed by #300
Assignees
@appilon
Labels
breaking-change Implementation which breaks compatibility or other promises bug Something isn't working
Milestone
v2.0.0

Comments

@teamterraform
Copy link
Contributor

As mentioned in hashicorp/terraform#17438 the function currently returns random integers within the range of 0...(max - min).
@hashibot hashibot transferred this issue from hashicorp/terraform Sep 26, 2019
@hashibot hashibot added breaking-change Implementation which breaks compatibility or other promises bug Something isn't working labels Oct 2, 2019
@paultyng paultyng added this to the v2.0.0 milestone Jan 6, 2020
alkar added a commit to alkar/terraform-plugin-sdk that referenced this issue Jan 17, 2020
@alkar
helper/acctest: fix RandIntRange (hashicorp#171)
e652103 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
@alkar alkar mentioned this issue Jan 17, 2020
Merged
appilon pushed a commit to alkar/terraform-plugin-sdk that referenced this issue Feb 6, 2020
@alkar @appilon
helper/acctest: fix RandIntRange (hashicorp#171)
d2613e1 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
appilon pushed a commit that referenced this issue Feb 11, 2020
@alkar @appilon
helper/acctest: fix RandIntRange (#171)
346391c 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
@paultyng
Copy link
Contributor

A fix for this is merged in to our v2 branch and will be included in that version.

@paultyng paultyng linked a pull request Feb 13, 2020 that will close this issue
helper/acctest: fix RandIntRange #300
Merged
appilon pushed a commit that referenced this issue Feb 13, 2020
@alkar @appilon
helper/acctest: fix RandIntRange (#171)
bd90afd 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
appilon pushed a commit that referenced this issue Feb 20, 2020
@alkar @appilon
helper/acctest: fix RandIntRange (#171)
ecc0c44 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
appilon pushed a commit that referenced this issue Mar 4, 2020
@alkar @appilon
helper/acctest: fix RandIntRange (#171)
650f425 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
appilon pushed a commit that referenced this issue Mar 11, 2020
@alkar @appilon
helper/acctest: fix RandIntRange (#171)
301e34a 
Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
@ghost
Copy link

ghost commented Mar 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@appilon appilon

Labels
breaking-change Implementation which breaks compatibility or other promises bug Something isn't working
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

helper/acctest: fix RandIntRange alkar/terraform-plugin-sdk
5 participants
@radeksimko @paultyng @hashibot @appilon @teamterraform