core: fix provider/close provider race when targeting #2527
Conversation
|
I'll follow up with a similar fix for provisioners |
|
It'd be interesting to see how this interact with provider aliases. It might work fine, but its still probably worth adding a test case for them. |
|
In addition to test outputs needing updates - this breaks the DisableProviderTransformer as well since that's looking for providers without descendents... looking into it... |
phinze
force-pushed
the
b-close-provider-target
branch
from
35ebf11 to
dce1772
Compare
When targeting prunes out all the resource nodes between a provider and its close node, there was no dependency to ensure the close happened after the configure. Needed to add an explicit dependency from the close to the provider. This tweak highlighted the fact that CloseProviderTransformer needed to happen after DisableProviderTransformer, since DisableProviderTransformer inspects up-edges to decide what to disable, and CloseProviderTransformer adds an up-edge. fixes #2495
phinze
force-pushed
the
b-close-provider-target
branch
from
dce1772 to
2d6a8c1
Compare
Not sure if this test has value /cc @mitchellh (who requested one be added) to see what I might be missing here. refs #2495
|
LGTM. You're right that that test probably isn't testing anything. I have an idea, going to hijack your branch for a second and see something. |
|
Hijack away! 🚀 |
fixes destroy-related failures introduced by the close transforms
phinze
force-pushed
the
b-close-provider-target
branch
from
2dc5e9b to
184edbe
Compare
|
Okay @mitchellh one more review - I think this is G2G. |
|
Yep yep LGTM |
core: fix provider/close provider race when targeting
|
👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
When targeting prunes out all the resource nodes between a provider and
its close node, there was no dependency to ensure the close happened
after the configure. Needed to add an explicit dependency from the close
to the provider.
fixes #2495