Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't attempt to operate on configuration that may be invalid during init #33788

Open
radditude opened this issue Sep 1, 2023 · 0 comments
Open
Assignees
Labels
enhancement new new issue not yet triaged

Comments

@radditude
Copy link
Member

radditude commented Sep 1, 2023

During the init process, we order validations carefully in order to present useful errors to the user as much as possible. Over time, this has led to situations where we may intentionally suppress validation errors and operate on possibly-invalid configuration, which leads to subtle bugs and even more confusing issues - for instance, we install remote modules before returning errors about whether the module blocks are valid so that we can return errors around core version requirements before doing anything else. This leads to situations like #33745 and #33628.

For the 1.7 series, let's conduct a more comprehensive review of our init operations to ensure that the configuration we need to operate on is valid before we do anything else with it at each step during init.

@radditude radditude self-assigned this Sep 1, 2023
@crw crw added enhancement new new issue not yet triaged labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new new issue not yet triaged
Projects
None yet
Development

No branches or pull requests

2 participants