Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Kinesis Firehose #3833

Merged
merged 6 commits into from
Nov 10, 2015
Merged

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 9, 2015

Introduction of Kinesis Firehose as per the request in #3830

  • schema
  • CRUD functionality
  • Acceptance Tests
  • Documentation

This implementation only takes into account the S3 destination as terraform doesn't support Redshift yet

make testacc TEST=./builtin/providers/aws TESTARGS='-run=KinesisFirehoseDeliveryStream' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=KinesisFirehoseDeliveryStream -timeout 90m
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_basic (133.32s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (158.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    291.470s

… the S3 configuration right now as Terraform doesn't include RedShift support
…le for and also that s3 is the only destination involved right now
@stack72 stack72 changed the title [WIP] provider/aws: Kinesis Firehose provider/aws: Kinesis Firehose Nov 10, 2015
}
```

~> **NOTE:** Kinesis Firehose is currently only support in us-east-1, us-west-2 and eu-west-1. This implementation of Kinesis Firehose only supports the s3 destination type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor typo here: support -> supported. It might also be worth calling out explicity that this resource only supports S3 as Terraform doesn't yet support Redshift.

Changing the AWS Kinesis Firehose docs as per @jen20's feedback
jen20 added a commit that referenced this pull request Nov 10, 2015
provider/aws: Add Kinesis Firehose resource
@jen20 jen20 merged commit 7c50e3e into hashicorp:master Nov 10, 2015
@stack72 stack72 deleted the aws-kinesis-firehose branch November 10, 2015 21:51
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants