Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3894 RDS publicly_accessible param shouldn't force new resource #3895

Merged
merged 3 commits into from
Nov 25, 2015

Conversation

br0ch0n
Copy link
Contributor

@br0ch0n br0ch0n commented Nov 12, 2015

should fix #3894

…w resource

Change-Id: I833f9e07f3fc1f6ee475673ad978b3982f0b6273
Change-Id: Ib4aaf478f4662b43961f80fbfd44199fca651180
@catsby
Copy link
Contributor

catsby commented Nov 13, 2015

Hey @br0ch0n thanks for the PR! I think we need to add Computed: true as well, since AWS will provide a default (though that default changes based on the VPC).

We also need to check for the change in resourceAwsDbInstanceUpdate as well, to update it accordingly. Think you can tack those on?

@catsby catsby added bug waiting-response An issue/pull request is waiting for a response from the community labels Nov 13, 2015
…w resource

Change-Id: I0a10e050ca1c4f2dde5e04f237de6115723522d8
@br0ch0n
Copy link
Contributor Author

br0ch0n commented Nov 17, 2015

added ( I think :) )

@catsby catsby removed the waiting-response An issue/pull request is waiting for a response from the community label Nov 19, 2015
@jen20
Copy link
Contributor

jen20 commented Nov 25, 2015

👍 LGTM. The ModifyDBInstance documentation confirms this operation should not require a new resource.

jen20 added a commit that referenced this pull request Nov 25, 2015
Issue #3894 RDS publicly_accessible param shouldn't force new resource
@jen20 jen20 merged commit c262bc7 into hashicorp:master Nov 25, 2015
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying RDS "publicly_accessible" parameter forces new resource
3 participants