provider/digitalocean: Do not force the creation of a new IP when the droplet_id changes #4476
Conversation
|
@radeksimko @jen20 Can we go ahead with this PR? |
| func resourceDigitalOceanFloatingIpUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*godo.Client) | ||
|
|
||
| if v, ok := d.GetOk("droplet_id"); ok { |
There was a problem hiding this comment.
We should probably check here whether there is a change prior to reassigning the floating IP?
|
Hi @ColinHebert! I've just looked over this - I left a comment inline. Thanks for opening the PR! |
|
@jen20 good suggestion. I updated the PR |
|
Hi @ColinHebert - looks like there are so |
|
I've fixed up the formatting and squashed these commits into |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #4299
The droplet_id isn't mandatory and the expected behaviour of the floating IP is to stick around even when the droplet is destroyed/recreated.