Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/docker: Add support for docker_volume #4480

Closed
wants to merge 14 commits into from

Conversation

ColinHebert
Copy link
Contributor

Fixes #4479

@ColinHebert
Copy link
Contributor Author

@jen20 @phinze Is it okay to merge this?

@jen20
Copy link
Contributor

jen20 commented Jan 15, 2016

Hi @ColinHebert! I've spent quite a while trying to rebase this onto master and test it. The docker_volume resource works well, and I've added in an acceptance test for that and altered the commit to credit you - the SHA is e887ac2 (and is merged to master).

However, I can't quite get the changes to docker_container into a state where they will start a container with a volume created via docker_container mounted. I will take another look at this soon, but if you get a chance before then could you rebase your changes to docker_container onto master, and add an acceptance test?

Thanks for your contributions to this area!

@jen20
Copy link
Contributor

jen20 commented Jan 15, 2016

Hi @ColinHebert - turns out it was actually pretty straightforward when I applied the patch again. I've also added an acceptance test covering this and merged it to master, so I'll close this PR. Thanks for your contribution to Terraform!

@jen20 jen20 closed this Jan 15, 2016
@ColinHebert ColinHebert deleted the docker_volumes branch January 30, 2016 21:28
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docker] Add support for docker volumes
3 participants