provider/azurerm: add subnet resource

[stack72]

@jen20 Scaffold the Azure RM Subnet resource

• Schema
• CRUD
• Acceptance Tests
• Documentation

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=AzureRMSubnet' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=AzureRMSubnet -timeout 120m
=== RUN   TestAccAzureRMSubnet_basic
--- PASS: TestAccAzureRMSubnet_basic (132.11s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    132.123s

the changes to the virtual_network resource is to mark subnets as Optional as they will compete with the use of azurerm_subnet

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=AzureRMVirtualNetwork' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=AzureRMVirtualNetwork -timeout 120m
=== RUN   TestAccAzureRMVirtualNetwork_basic
--- PASS: TestAccAzureRMVirtualNetwork_basic (125.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    125.140s

[jen20]

Is it necessary here to use either all inline subnets or all separate resources? If so we should document this here and in the subnet doc.

[stack72]

@jen20 this is exactly the same behaviour as for Network Security Group / Network Security Rule

From Slack (with @phinze):

stack72 [2:01 PM] 
oh they can’t be mixed?

phinze [2:01 PM] 
right because they'll always fight

stack72 [2:01 PM] 
ah so you would set up a basic network_acl and ​*then add*​ the rules?

​[2:01] 
now i see

​[2:01] 
that makes more sense

phinze [2:01 PM] 
yep, all nested or all _rule is the key

[jen20]

LGTM. I put a comment in line but it doesn't affect the operation of it and we can make that change later if it is deemed necessary. Thanks @stack72!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.