Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for CloudTrail tags #5135

Merged
merged 3 commits into from
Feb 16, 2016

Conversation

radeksimko
Copy link
Member

Acceptance tests

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSCloudtrail'

@stack72
Copy link
Contributor

stack72 commented Feb 16, 2016

@radeksimko this looks good! I had to run a different command for the tests:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSCloudTrail'

But got the following results:

ake testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSCloudTrail'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run=AWSCloudTrail -timeout 120m
=== RUN   TestAccAWSCloudTrail_basic
--- PASS: TestAccAWSCloudTrail_basic (41.89s)
=== RUN   TestAccAWSCloudTrail_enable_logging
--- PASS: TestAccAWSCloudTrail_enable_logging (55.87s)
=== RUN   TestAccAWSCloudTrail_is_multi_region
--- PASS: TestAccAWSCloudTrail_is_multi_region (54.72s)
=== RUN   TestAccAWSCloudTrail_logValidation
--- PASS: TestAccAWSCloudTrail_logValidation (43.55s)
=== RUN   TestAccAWSCloudTrail_tags
--- PASS: TestAccAWSCloudTrail_tags (60.03s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    256.080s

stack72 added a commit that referenced this pull request Feb 16, 2016
provider/aws: Add support for CloudTrail tags
@stack72 stack72 merged commit 77deff1 into hashicorp:master Feb 16, 2016
@radeksimko radeksimko deleted the f-aws-cloudtrail-tags branch February 16, 2016 21:56
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants