provider/aws: Enable updates & versioning for s3_bucket_object

[radeksimko]

This is closing #3068 and will help finishing #5239

It also introduces a breaking change - etag is now returned without quotes - frankly I don't see the "quoted" version being useful in any context.

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSS3BucketObject'

TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run=AWSS3BucketObject -timeout 120m
=== RUN   TestAccAWSS3BucketObject_source
--- PASS: TestAccAWSS3BucketObject_source (96.96s)
=== RUN   TestAccAWSS3BucketObject_content
--- PASS: TestAccAWSS3BucketObject_content (36.43s)
=== RUN   TestAccAWSS3BucketObject_withContentCharacteristics
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (37.41s)
=== RUN   TestAccAWSS3BucketObject_updates
--- PASS: TestAccAWSS3BucketObject_updates (58.90s)
=== RUN   TestAccAWSS3BucketObject_updatesWithVersioning
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (60.36s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    290.076s

[stack72]

why doesn't the Put call the Read? I know you didn't change this part but seems like it should

[radeksimko]

well, I guess I didn't feel the need for the extra API call as the output from Put call is providing the basic stuff already? But I don't mind adding it 😉

I guess better safe than sorry!

[stack72]

I don't mind that it's not in place - if you feel it's good then i am good with it

[stack72]

1 small query around Put -> read not happening (as normal convention). But apart form that it looks good and the tests run:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSS3BucketObject'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSS3BucketObject -timeout 120m
=== RUN   TestAccAWSS3BucketObject_source
--- PASS: TestAccAWSS3BucketObject_source (30.76s)
=== RUN   TestAccAWSS3BucketObject_content
--- PASS: TestAccAWSS3BucketObject_content (31.57s)
=== RUN   TestAccAWSS3BucketObject_withContentCharacteristics
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (29.79s)
=== RUN   TestAccAWSS3BucketObject_updates
--- PASS: TestAccAWSS3BucketObject_updates (47.46s)
=== RUN   TestAccAWSS3BucketObject_updatesWithVersioning
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (49.30s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    188.905s

[radeksimko]

Added the Put -> Read call as requested, also I reran acceptance tests -> all OK, just waiting for Travis now, then I'll merge it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.