Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for CloudWatch Log Metric Filter #5444

Merged
merged 5 commits into from
Mar 21, 2016

Conversation

radeksimko
Copy link
Member

TODO

  • Basic CRUD functionality
  • Documentation
  • Acceptance test
  • Add field validation per AWS API Docs
  • Try out the new schema parameter MaxItems instead of len() function in Create()
  • Be able to recover from filter deleted outside of Terraform
  • Improve acceptance tests by adding checks of the actual cloudwatchlogs.MetricFilter type
  • Mention link to filter and pattern syntax in docs
  • Figure out if raising awserr.Error is the best way to deal with missing resource

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSCloudWatchLogMetricFilter'
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSCloudWatchLogMetricFilter -timeout 120m
=== RUN   TestAccAWSCloudWatchLogMetricFilter_basic
--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (17.98s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    18.004s

@radeksimko radeksimko force-pushed the f-aws-logs-metric-filter branch 4 times, most recently from f5a8ba1 to 4edb620 Compare March 8, 2016 10:45
@radeksimko radeksimko force-pushed the f-aws-logs-metric-filter branch 2 times, most recently from a21aaaf to eaec4e6 Compare March 15, 2016 13:03
@radeksimko radeksimko changed the title [WIP] provider/aws: Add support for CloudWatch Log Metric Filter provider/aws: Add support for CloudWatch Log Metric Filter Mar 15, 2016
@radeksimko radeksimko force-pushed the f-aws-logs-metric-filter branch from fd6f0e1 to af93183 Compare March 15, 2016 15:01
@jen20
Copy link
Contributor

jen20 commented Mar 21, 2016

Thanks @radeksimko! This LGTM!

jen20 added a commit that referenced this pull request Mar 21, 2016
provider/aws: Add support for CloudWatch Log Metric Filter
@jen20 jen20 merged commit f946695 into hashicorp:master Mar 21, 2016
@radeksimko radeksimko deleted the f-aws-logs-metric-filter branch March 21, 2016 17:00
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants